From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Re: [PATCH] clocksource=tsc
Date: Fri, 18 Jul 2008 20:28:13 +0100
Message-ID: <C4A6AD5D.1B455%keir.fraser@eu.citrix.com>
References: <20080718105135031.00000001344@djm-pc>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20080718105135031.00000001344@djm-pc>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "dan.magenheimer@oracle.com" <dan.magenheimer@oracle.com>, "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
Cc: Dave Winchell <dwinchell@virtualiron.com>
List-Id: xen-devel@lists.xenproject.org

On 18/7/08 17:51, "Dan Magenheimer" <dan.magenheimer@oracle.com> wrote:

> I guess you are correct as long as "generate a time record"
> doesn't include recomputing the scaling factor every
> second (which is I think what introduces the jitter... see
> more on this below).
> 
> However, I'm not sure why you perceive the aesthetics to
> be so bad to put "if (ideal_clocksource)" in get_s_time()
> and a few other places in time.c... or for that matter in
> the PV guest code.

Extra special case are ugly. And then if they extend into the guests then
you also have to worry about new guests on old Xen and old guests on new Xen
(i.e., compatibility both ways). Which is not a good way to go when there is
an easy way to hide this new implementation from guests. Indeed we would
only update the TSC and system-time stamps -- the scale factor would never
change.

 -- Keir