From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] x86: adjust placement of pause insn in
	_raw_spin_lock()
Date: Fri, 08 Aug 2008 15:02:55 +0100
Message-ID: <C4C2109F.2545B%keir.fraser@eu.citrix.com>
References: <C4C204D9.2544D%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C4C204D9.2544D%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Ah, I suppose it reduce lock acquisition latency slightly. I'll apply it.

 -- Keir

On 8/8/08 14:12, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

> Why?
> 
>  -- Keir
> 
> On 8/8/08 13:49, "Jan Beulich" <jbeulich@novell.com> wrote:
> 
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>> 
>> Index: 2008-08-06/xen/include/asm-x86/spinlock.h
>> ===================================================================
>> --- 2008-08-06.orig/xen/include/asm-x86/spinlock.h 2007-09-10
>> 09:59:37.000000000 +0200
>> +++ 2008-08-06/xen/include/asm-x86/spinlock.h 2008-08-07 12:36:13.000000000
>> +0200
>> @@ -23,8 +23,8 @@ static inline void _raw_spin_lock(spinlo
>>          "1:  lock; decb %0         \n"
>>          "    js 2f                 \n"
>>          ".section .text.lock,\"ax\"\n"
>> -        "2:  cmpb $0,%0            \n"
>> -        "    rep; nop              \n"
>> +        "2:  rep; nop              \n"
>> +        "    cmpb $0,%0            \n"
>>          "    jle 2b                \n"
>>          "    jmp 1b                \n"
>>          ".previous"
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel