From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH][XEN] public header: portability
Date: Thu, 21 Aug 2008 11:18:41 +0100
Message-ID: <C4D2FF91.263C1%keir.fraser@eu.citrix.com>
References: <C4D2FECD.263B2%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C4D2FECD.263B2%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 21/8/08 11:15, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

> On 21/8/08 11:03, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> 
>> Attached patch defines xen_*mb() macros for NetBSD.
>> 
>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> 
> Since this has presumably never worked unmodified for NetBSD, it's not a
> compatibility issue. You should simply specify __XEN_INTERFACE_VERSION__ >=
> 0x00030208 and fix up any small build breakages that this causes in the NetBSD
> kernel sources.

Actually I suspect you're not specifying __XEN_INTERFACE_VERSION__ at all
right now. The easiest way to do so is to add it to your CPPFLAGS
(-D__XEN_INTERFACE_VERSION__=<whatever>), or NetBSD build system equivalent,
then it definitely gets defined correctly everywhere that you include Xen
public header files.

 -- Keir