From mboxrd@z Thu Jan  1 00:00:00 1970
From: Grant Erickson <gerickson@nuovations.com>
Date: Fri, 29 Aug 2008 20:32:39 -0700
Subject: [U-Boot] [RFC] Suppressing Diagnostic Output for 'fw_setenv'
Message-ID: <C4DE0D67.115B5%gerickson@nuovations.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

The u-boot companion command line tool 'fw_setenv' emits verbose output
during a set operation of the form:

    Unlocking flash...
    Done
    Erasing old environment...
    Done
    Writing environment to /dev/mtd4...
    Done
    Locking ...
    Done

While this is nice for debugging and troubleshooting, it is a bit verbose in
a production environment. I propose two alternatives for suppressing this
output:

1) Compile-time: Change 'printf' to 'debug' in which case the above
   diagnostics will only be output when the tool is built with 'DEBUG'
   asserted.

2) Run-time: Change the implementation such that the invocation usage of
   'fw_setenv' is:

    Usage: fw_setenv [ -q ] name [ value ... ]

I'd favor (2); however, I welcome strong opinions one way or another before
I submit a patch.

Regards,

Grant