From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer
	intr while force hpetbroadcast
Date: Wed, 10 Sep 2008 11:15:42 +0100
Message-ID: <C4ED5CDE.26F1B%keir.fraser@eu.citrix.com>
References: <8FED46E8A9CA574792FC7AACAC38FE7701ACA5C4B4@PDSMSX501.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <8FED46E8A9CA574792FC7AACAC38FE7701ACA5C4B4@PDSMSX501.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Wei, Gang" <gang.wei@intel.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 9/9/08 09:28, "Wei, Gang" <gang.wei@intel.com> wrote:

>> From above sequences, we can find this case will either introduce extra HPET
>> intrs or put off the softtimer expiring.
> This patch simply stops the LAPIC timer first (avoid immediate unnecessary
> expiring) and raise a softirq (continue the softtimer handling process, which
> will correct the LAPIC timer) when reprogram LAPIC timer fails.

It's not clear to me the disable/enable_LAPIC_timer() work is worthwhile for
the few timer interrupts it is likely to avoid. The other bit of the patch
is a good bugfix though. I've taken just the latter part.

 -- Keir