From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intr while force hpetbroadcast Date: Thu, 11 Sep 2008 08:38:06 +0100 Message-ID: References: <8FED46E8A9CA574792FC7AACAC38FE7701ACD18DCE@PDSMSX501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8FED46E8A9CA574792FC7AACAC38FE7701ACD18DCE@PDSMSX501.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Wei, Gang" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 10/9/08 15:25, "Wei, Gang" wrote: >> It's not clear to me the disable/enable_LAPIC_timer() work is worthwhile for >> the few timer interrupts it is likely to avoid. The other bit of the patch >> is a good bugfix though. I've taken just the latter part. > > Thanks for accept most of these patches. As to disable/enable_LAPIC_timer(), I > add them because some platforms require the LAPIC timer intr being disabled > before entering C3, otherwise there may be some unexpected things. As a > reference, Linux kernel always do so. Is this a documented aspect of C3, or just one of those things? Do you know what kind of 'unexpected things' can happen? -- Keir