From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] linux: prevent invalid or unsupportable PIRQs from being used
Date: Wed, 05 Nov 2008 14:54:12 +0000 [thread overview]
Message-ID: <C5376414.28C3F%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4911B833.76E4.0078.0@novell.com>
On 5/11/08 14:13, "Jan Beulich" <jbeulich@novell.com> wrote:
> By keeping the respective irq_desc[] entries pointing to no_irq_type,
> setup_irq() (and thus request_irq()) will fail for such IRQs. This
> matches native behavior, which also only installs ioapic_*_type out of
> ioapic_register_intr().
>
> At the same time, make assign_irq_vector() fail not only when Xen
> doesn't support the PIRQ, but also if the IRQ requested doesn't fall
> in the kernel's PIRQ space.
Reverted as it breaks the build non-trivially (at least: no
set_irq_chip_and_handler_name(); no pirq_chip structure). The 2.6.18 isn't
really the place for big code restructurings anyway (this was a big patch).
-- Keir
next prev parent reply other threads:[~2008-11-05 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 14:13 [PATCH] linux: prevent invalid or unsupportable PIRQs from being used Jan Beulich
2008-11-05 14:54 ` Keir Fraser [this message]
2008-11-05 15:27 ` [PATCH] linux: prevent invalid or unsupportablePIRQs " Jan Beulich
2008-11-05 15:20 ` [PATCH] linux: prevent invalid or unsupportable PIRQsfrom " Jan Beulich
2008-11-05 15:26 ` Keir Fraser
2008-11-05 15:30 ` [PATCH] linux: prevent invalid or unsupportablePIRQsfrom " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5376414.28C3F%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.