From: Keir Fraser <keir.fraser@eu.citrix.com>
To: mukesh.rathor@oracle.com, xen-devel@lists.xensource.com
Cc: Tim Deegan <tim.deegan@eu.citrix.com>
Subject: Re: debuggers and hap_gva_to_gfn() in guest_walk.c
Date: Wed, 05 Nov 2008 21:56:37 +0000 [thread overview]
Message-ID: <C537C715.1EEB2%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <491213BF.8040300@oracle.com>
This looks like a bug in hap_gva_to_gfn(). It should probably be using
gfn_to_mfn() rather than gfn_to_mfn_current(). Tim, can you confirm?
-- Keir
On 5/11/08 21:44, "Mukesh Rathor" <mukesh.rathor@oracle.com> wrote:
>
> Debugger/s would like to keep it's #ifdefs in xen minimal. Following would
> help...
>
> hap_gva_to_gfn():
>
>
> + if (v== current)
> mfn = mfn_x(gfn_to_mfn_current(gpfn, &p2mt));
> + else
> + mfn = mfn_x(gfn_to_mfn_foreign(v->domain, gpfn, &p2mt));
>
>
> Thanks,
> Mukesh
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2008-11-05 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 21:44 debuggers and hap_gva_to_gfn() in guest_walk.c Mukesh Rathor
2008-11-05 21:56 ` Keir Fraser [this message]
2008-11-06 10:51 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C537C715.1EEB2%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=mukesh.rathor@oracle.com \
--cc=tim.deegan@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.