From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: several Qs about domain live migration
Date: Tue, 18 Nov 2008 09:12:19 +0000
Message-ID: <C5483773.1F518%keir.fraser@eu.citrix.com>
References: <49227B56.4090602@intel.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <49227B56.4090602@intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Zhai, Edwin" <edwin.zhai@intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, Xen Developers <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 18/11/08 08:22, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:

>> Try changing gmfn_to_mfn(FOREIGNDOM, l1e_get_pfn(nl1e)) in mod_l1_entry()
>> to:
>>   mfn = gfn_to_mfn(FOREIGNDOM, l1e_get_pfn(nl1e), &p2mt);
>>   if ( !p2m_is_ram(p2mt) || (mfn == INVALID_MFN) )
>>     ....
>> 
>> This will prevent foreign mappings of 'mmio' pages. Pretty sensible and will
>> fix this problem.
>>   
> 
> It's great!
> Does p2m_is_ram return 1 for video memory?

Yes, since it is just ordinary guest memory. That was the point of Samuel's
patch.

 -- Keir

> I'll make a small patch and test it.