All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>, Haitao Shan <haitao.shan@intel.com>
Cc: "'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X across Dom0 S3
Date: Mon, 24 Nov 2008 12:03:37 +0000	[thread overview]
Message-ID: <C5504899.2950B%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <492AA0F0.76E4.0078.0@novell.com>

On 24/11/08 11:41, "Jan Beulich" <jbeulich@novell.com> wrote:

>>>> "Shan, Haitao" <haitao.shan@intel.com> 24.11.08 12:03 >>>
>> With this patch, MSI/MSI-X capabilities and tables are saved in Dom0 when
>> S3 and restored when resume. Actually, this is also the approach that
>> kernel takes. The only concern is that Dom0 should not touch MSI/MSI-X,
>> they are owned by VMM itself. Maybe adding a hypercall to instruct Xen to
>> do the saving/restoring is good. I wonder whether the reason is strong
>> enough for adding a hypercall for such purpose.
> 
> Is it at all necessary to use a hypercall here? Shouldn't Xen itself be able
> to
> do the necessary saving/restoring (just like it does for IO-APIC)?

I was thinking the same thing. Haitao: shall I hold off on your original
patch while we think about this?

 -- Keir

  reply	other threads:[~2008-11-24 12:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 11:03 [PATCH] Dom0 Kernel - Fixes for saving/restoring MSI/MSI-X across Dom0 S3 Shan, Haitao
2008-11-24 11:41 ` [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X " Jan Beulich
2008-11-24 12:03   ` Keir Fraser [this message]
2008-11-24 12:53     ` Tian, Kevin
2008-11-24 13:35       ` [PATCH] Dom0 Kernel - Fixes forsaving/restoringMSI/MSI-X " Jan Beulich
2008-11-24 13:45         ` Tian, Kevin
2008-11-24 13:55           ` Shan, Haitao
2008-11-24 15:32             ` Jan Beulich
2008-11-25  1:21               ` Shan, Haitao
2008-11-24 13:45     ` [PATCH] Dom0 Kernel - Fixes for saving/restoringMSI/MSI-X " Shan, Haitao
2008-11-24 14:15 ` [PATCH] Dom0 Kernel - Fixes for saving/restoring MSI/MSI-X " Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C5504899.2950B%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=haitao.shan@intel.com \
    --cc=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.