From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Dom0 Kernel - Fixes for saving/restoring MSI/MSI-X across Dom0 S3 Date: Mon, 24 Nov 2008 14:15:00 +0000 Message-ID: References: <61563CE63B4F854986A895DA7AD3C17701FC57FF@pdsmsx502.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <61563CE63B4F854986A895DA7AD3C17701FC57FF@pdsmsx502.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Shan, Haitao" Cc: "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org On 24/11/08 11:03, "Shan, Haitao" wrote: > With this patch, MSI/MSI-X capabilities and tables are saved in Dom0 when S3 > and restored when resume. Actually, this is also the approach that kernel > takes. The only concern is that Dom0 should not touch MSI/MSI-X, they are > owned by VMM itself. Maybe adding a hypercall to instruct Xen to do the > saving/restoring is good. I wonder whether the reason is strong enough for > adding a hypercall for such purpose. > > So Keir, maybe you can tell what is your prefer? I think the approach in your patch is okay for now. -- Keir