From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>,
Geoffrey Lefebvre <geoffrey@cs.ubc.ca>
Cc: Andrew Warfield <andy@cs.ubc.ca>, Dutch Meyer <dmeyer@cs.ubc.ca>,
Samvel Yuri <samvelox@yahoo.com>,
xen-devel <xen-devel@lists.xensource.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH] multi-page blkfront/blkback patch
Date: Fri, 28 Nov 2008 09:22:57 +0000 [thread overview]
Message-ID: <C55568F1.1FA70%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <492FBCE4.76E4.0078.0@novell.com>
On 28/11/08 08:41, "Jan Beulich" <jbeulich@novell.com> wrote:
>> +#ifndef CONFIG_XEN_BLKDEV_NUM_RING_PAGES
>> +#error "CONFIG_XEN_BLKDEV_NUM_RING_PAGES undefined!"
>> +#endif
>
> This won't work when building unmodified_drivers - I'm not sure what value
> to default to here, though. But for compatibility it should probably be 1,
> and the unmodified drivers' Kbuild could override it if desired.
It should be a module parameter anyway. I don't think there's anything
particularly hard about choosing ring size at run time rather than build
time.
-- Keir
next prev parent reply other threads:[~2008-11-28 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-28 2:17 [PATCH] multi-page blkfront/blkback patch Geoffrey Lefebvre
2008-11-28 8:41 ` Jan Beulich
2008-11-28 9:22 ` Keir Fraser [this message]
2008-12-01 6:49 ` Samvel Yuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C55568F1.1FA70%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=andy@cs.ubc.ca \
--cc=dmeyer@cs.ubc.ca \
--cc=geoffrey@cs.ubc.ca \
--cc=jbeulich@novell.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=samvelox@yahoo.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.