From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re:
	[PATCH 2/2] linux/x86: use shared page indicating the need
	for an EOI notification)
Date: Tue, 09 Dec 2008 11:06:58 +0000
Message-ID: <C56401D2.1FFE2%keir.fraser@eu.citrix.com>
References: <493E5C91.76E4.0078.0@novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <493E5C91.76E4.0078.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <jbeulich@novell.com>, Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On 09/12/2008 10:54, "Jan Beulich" <jbeulich@novell.com> wrote:

>>>> Isaku Yamahata <yamahata@valinux.co.jp> 09.12.08 11:43 >>>
>> You are the first person to pass the kernel symbol address
>> to virt_to_machine() in arch independent code.
>> Is there any necessity to allocate pirq_needs_eoi statically?
>> (except it did before)
> 
> Perhaps not - avoiding the possible allocation failure (-> BUG()) and the
> extra indirection were the main reasons I kept it allocated statically.
> 
>> If no, can we allocate the pages for them dynamically?
>> Then the issue will go away.
> 
> Indeed.

Yes please. Just do this and be done. It's a one-off start-of-day allocation
which, if it fails, means you're screwed anyway.

 -- Keir