From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Jan Beulich <jbeulich@novell.com>,
Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re:[PATCH 2/2] linux/x86: use shared page indicatingthe need for an EOI notification)
Date: Wed, 10 Dec 2008 10:07:54 +0000 [thread overview]
Message-ID: <C565457A.2004E%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <493F982A.76E4.0078.0@novell.com>
On 10/12/2008 09:21, "Jan Beulich" <jbeulich@novell.com> wrote:
>>>> Isaku Yamahata <yamahata@valinux.co.jp> 10.12.08 05:16 >>>
>> Sorry I sent out the old one. Here is the corrected one.
>> NULL check must be before its use.
>
> Not really - alloc_bootmem() etc panic for themselves unless you use the
> _nopanic variants.
> Also, alloc_bootmem() etc zero the allocated memory, so no need for
> memset(), and the subsequent BUG_ON() can obviously go away.
> And finally, PAGE_SIZE isn't correct, you should use the size originally
> used, just slightly modified:
>
> BITS_TO_LONGS(ALIGN(NR_PIRQS, PAGE_SIZE * 8))
>
> I was about to put together a patch for this myself...
Can you just fix up Isaku's patch and then we'll collect a fresh sign-off
from him too?
-- Keir
next prev parent reply other threads:[~2008-12-10 10:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 13:36 [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re: [PATCH 2/2] linux/x86: use shared page indicating the need for an EOI notification) Jan Beulich
2008-12-09 3:40 ` Isaku Yamahata
2008-12-09 10:04 ` Jan Beulich
2008-12-09 10:43 ` Isaku Yamahata
2008-12-09 10:54 ` Jan Beulich
2008-12-09 11:06 ` Keir Fraser
2008-12-10 4:08 ` Isaku Yamahata
2008-12-10 4:16 ` Isaku Yamahata
2008-12-10 9:21 ` [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re:[PATCH 2/2] linux/x86: use shared page indicatingthe " Jan Beulich
2008-12-10 10:07 ` Keir Fraser [this message]
2008-12-10 10:23 ` [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (wasRe:[PATCH 2/2] linux/x86: use shared page indicatingthe need foran " Jan Beulich
2008-12-10 4:09 ` [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re: [PATCH 2/2] linux/x86: use shared page indicating the need for an " Isaku Yamahata
2008-12-10 7:59 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C565457A.2004E%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=jbeulich@novell.com \
--cc=xen-devel@lists.xensource.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.