From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] x86: fix the potential of encountering panic
	"IO-APIC + timer doesn't work! ..."
Date: Thu, 11 Dec 2008 11:14:23 +0000
Message-ID: <C566A68F.B49%keir.fraser@eu.citrix.com>
References: <4940FBFA.76E4.0078.0@novell.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4940FBFA.76E4.0078.0@novell.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <jbeulich@novell.com>, xen-devel@lists.xensource.com
Cc: Ingo Molnar <mingo@elte.hu>
List-Id: xen-devel@lists.xenproject.org

On 11/12/2008 10:39, "Jan Beulich" <jbeulich@novell.com> wrote:

> I have to admit that in addition I find it quite disturbing that there
> is a dependency on the side effect of smp_prepare_cpus()
> (check_nmi_watchdog() or until now setup_IO_APIC()) or init_xen_time()
> (init_platform_timer() -> plt_overflow()) enabling interrupts: c/s 5604
> removed the explicit local_irq_enable() from start_of_day() (which is
> __start_xen() now), putting it into init_xen_time(). There it got
> removed by c/s 18698, without an explicit replacement. I'd think there
> should be an explicit local_irq_enable() in __start_xen() in any case,
> and as early as reasonable (i.e. the latest before smp_prepare_cpus()).

Sounds reasonable. Send a patch.

 -- Keir