From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [patch 0/3]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs Date: Tue, 23 Dec 2008 08:40:18 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Ke, Liping" Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 23/12/2008 05:17, "Ke, Liping" wrote: > Thanks a lot for the clean-up and format refine! I will pay more attention to > this too.And also I tested on the related platform. It's fine. > > As for moving *cmci_owner_set* out of stopmachine_run is basically ok for us. > Just one thing: > CMCI might happen and lost during the very small window (old owner is cleared > while new owner is not set). In order to make sure that CMCI could be > triggered an on the new owner, we need to clear MSR Bank(i) status register > [Corrected Error Counter] field ( We normally do this @ CMCI interrupt > handler, according to spec, if the counter is not cleared, CMCI will not be > triggered any more). > I made a small patch for it in the attachment. How do you think? I don't know very much about CMCI. If you think this is required I will certainly check it in. -- Keir