From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Re: [patch 0/3]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs Date: Wed, 24 Dec 2008 14:55:27 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" , "Ke, Liping" Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 24/12/2008 14:51, "Jiang, Yunhong" wrote: >>> Yes, that's what I mean of "do similar thing in the >> cmci_cpu_down()". We >>> placed it in stop_machine_run() because it has rendezvous >> all CPU already :$ >> >> Yeah, on_each_cpu() rendezvous is pretty cheap. May as well >> have cleaner >> partitioned code than avoid an extra rendezvous. > > I'd have a bit clarification here. Simply harirqs disabled in the > on_each_cpu() is not enough. What we need is, firstly make sure every CPU has > irq disabled, then every CPU begin update the CMCI status. If this is what you > mean, we will take a patch for it later. Every CPU will have IRQs disabled on entry to the on_each_cpu() IPI function. I couldn't mean much else -- for example, it's not even valid for the caller of on_each_cpu() to enter it with IRQs disabled. -- Keir