From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay02.pair.com (relay02.pair.com [209.68.5.16]) by ozlabs.org (Postfix) with SMTP id 0D6D9474D7 for ; Wed, 7 Jan 2009 13:11:22 +1100 (EST) Date: Tue, 06 Jan 2009 18:11:11 -0800 Subject: Re: [PATCH/RFC] Add Alternative Log Buffer Support for printk Messages From: Grant Erickson To: Benjamin Herrenschmidt Message-ID: In-Reply-To: <1231286642.14860.35.camel@pasglop> Mime-version: 1.0 Content-type: text/plain; charset="US-ASCII" Cc: linuxppc-dev@ozlabs.org, Stefan Roese , Wolfgang Denx , linux-embedded@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 1/6/09 4:04 PM, Benjamin Herrenschmidt wrote: > On Tue, 2008-11-25 at 10:34 -0800, Grant Erickson wrote: >> This merges support for the previously DENX-only kernel feature of >> specifying an alternative, "external" buffer for kernel printk >> messages and their associated metadata. In addition, this ports >> architecture support for this feature from arch/ppc to arch/powerpc. >> >> Signed-off-by: Grant Erickson > > Considering the extensive changes to generic code, this patch will > have to be submitted via the linux-kernel mailing list. > > I suggest you split the generic core change from the powerpc specific > implementation. > > I'm not sure whether I like the idea myself or not there, so you'll have > to convince the powers that be to take it. Ben: Thanks for the feedback. Matt Sealey had some good feedback which I have on my to-do list to evaluate. In the interim, I'll hold off on pushing up to linux-kernel until I've done that. Regards, Grant