All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Cihula, Joseph" <joseph.cihula@intel.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: xen_phys_start for 32b
Date: Wed, 07 Jan 2009 15:40:36 +0000	[thread overview]
Message-ID: <C58A7D74.20D26%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4F65016F6CB04E49BFFA15D4F7B798D92D483E58@orsmsx506.amr.corp.intel.com>

On 07/01/2009 15:13, "Cihula, Joseph" <joseph.cihula@intel.com> wrote:

>>> But shouldn't [xenheap_phys_start, xenheap_phys_end] represent all of the
>>> memory that the hypervisor "owns" and which must be protected from even
>>> privileged domain writes (modulo the real mode/trampoline code, which has
>>> its
>>> own variables that represent its range)?  While it may be "OK" on 32b
>>> systems,
>>> it is not "logically correct" and does not match 64b systems (where this low
>>> memory is not so protected).  Would it break anything to set
>>> xenheap_phys_start to __pa(&_start) for 32b builds?
>> 
>> So what issue does this fix for you?
> 
> It moves the '#ifdef __x86_64__' in a couple of places in an upcoming patch
> into just setup.c ;-)  So practically speaking, it is not very important.  But
> it seems like it would just be cleaner, today, to have this variable (and
> xen_phys_start?) be consistent across builds; and thus, usable with the
> intended meaning in the future.

Xenheap will disappear entirely on x86/64 in future. So long term is that
i386 and x86/64 are actually to diverge significantly in this area.

Of course I'll consider any patch on its own merits of usefulness and
cleanliness.

 -- Keir

  reply	other threads:[~2009-01-07 15:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06  6:36 xen_phys_start for 32b Cihula, Joseph
2009-01-06  8:42 ` Keir Fraser
2009-01-06 18:29   ` Cihula, Joseph
2009-01-06 22:12     ` Keir Fraser
2009-01-06 22:19       ` Cihula, Joseph
2009-01-07  8:54         ` Keir Fraser
2009-01-07 15:13           ` Cihula, Joseph
2009-01-07 15:40             ` Keir Fraser [this message]
2009-01-07 21:37               ` Cihula, Joseph
2009-01-07 23:27                 ` Keir Fraser
2009-01-08  0:17               ` Xenheap disappearance: (was: xen_phys_start for 32b) Dan Magenheimer
2009-01-08  9:04                 ` Keir Fraser
2009-01-08 17:53                   ` Dan Magenheimer
2009-01-14 22:45                   ` Dan Magenheimer
2009-01-15  0:27                     ` Dan Magenheimer
2009-01-15  1:48                       ` Dan Magenheimer
2009-01-15  8:38                     ` Keir Fraser
2009-01-15  8:41                       ` Keir Fraser
2009-01-15 18:15                       ` Dan Magenheimer
2009-01-15 18:51                         ` Keir Fraser
2009-01-16  8:11                           ` Re: Xenheap disappearance: (was: xen_phys_start for32b) Jan Beulich
2009-01-16 23:16                             ` Dan Magenheimer
2009-01-19  8:22                               ` Re: Xenheap disappearance: (was: xen_phys_startfor32b) Jan Beulich
2009-01-19 20:04                                 ` Dan Magenheimer
2009-01-20  9:11                                   ` Re: Xenheap disappearance: (was:xen_phys_startfor32b) Jan Beulich
2009-01-20  9:16                                     ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C58A7D74.20D26%keir.fraser@eu.citrix.com \
    --to=keir.fraser@eu.citrix.com \
    --cc=joseph.cihula@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.