From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: Xenheap disappearance: (was: xen_phys_start for 32b) Date: Thu, 15 Jan 2009 08:38:37 +0000 Message-ID: References: <414df624-72b4-4367-aa38-979286b39a88@default> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <414df624-72b4-4367-aa38-979286b39a88@default> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 14/01/2009 22:45, "Dan Magenheimer" wrote: > Thinking about this a bit more, unless you plan to stop > supporting 32-bit Xen anytime soon, the semantic differences > probably warrant adding a second interface, let's call > it admalloc() (ad == anonymous domain), that should only be > used in 64-bit-only code where it can be guaranteed that > usage of pointers to the alloc'ed memory need not be bracketed > with (ugly) map/unmap_domain_page() calls. > > So I'd suggest adding _admalloc() and adfree() to xmalloc_tlsf.c > and when ifdef x86_64, _xmalloc and xfree simply get redefined > to _admalloc/adfree in xmalloc_tlsf.h. > > If this sounds sensible, I will spin a patch as I'm the one keen > to get this settled. Xmalloc/xfree can use alloc_domheap_pages always on x86/64. A temporary ifdef inside xmalloc is better than an extra xmalloc interface. -- Keir