From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH 0/6] MSI-INTx interrupt translation for HVM
Date: Mon, 02 Mar 2009 08:47:53 +0000
Message-ID: <C5D14DB9.3DB4%keir.fraser@eu.citrix.com>
References: <20090302161339.8372.CB716985@necst.nec.co.jp>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090302161339.8372.CB716985@necst.nec.co.jp>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Shohei Fujiwara <fujiwara-sxa@necst.nec.co.jp>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Qing He <qing.he@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 02/03/2009 07:19, "Shohei Fujiwara" <fujiwara-sxa@necst.nec.co.jp> wrote:

> Today, I found the hypervisor issues EOI ASAP. So Qing's explanation
> reflected the implementation of the hypervisor.
> 
> xen/drivers/passthrough/io.c:
> void hvm_dirq_assist(struct vcpu *v)
> {
> ...
>             if ( hvm_irq_dpci->mirq[irq].flags & HVM_IRQ_DPCI_TRANSLATE )
>             {
>                 /* for translated MSI to INTx interrupt, eoi as early as
> possible */
>                 __msi_pirq_eoi(d, irq);
>             }

Ah, well the passthrough-specific logic is not something I'm so familiar
with! That above code indeed doesn't look correct. :-)

 -- Keir