From: Keir Fraser <keir.fraser@eu.citrix.com>
To: "Jiang, Yunhong" <yunhong.jiang@intel.com>,
Tim Deegan <Tim.Deegan@eu.citrix.com>,
Gianluca Guida <Gianluca.Guida@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH]Add a flag for shadow pages
Date: Wed, 04 Mar 2009 16:45:30 +0000 [thread overview]
Message-ID: <C5D460AA.4191%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <E2263E4A5B2284449EEBD0AAB751098401C7C9DEA9@PDSMSX501.ccr.corp.intel.com>
On 04/03/2009 16:01, "Jiang, Yunhong" <yunhong.jiang@intel.com> wrote:
> Thanks for your really quick-hand implementation. I will update my another
> patch accordingly tomorrow.
>
> So still one question to the two assertion (or to Tim??) in
> sh_rm_write_access_from_sl1p()/sh_put_ref(). What's the potential error to be
> protected by this checking? If page is a shadow, it's count_info will always
> be 0, right? Or it is just a sanity checking?
>
> I need change this is because, if we mark a page offline, then the count_info
> is not 0, even for shadow page. Can I just checking the count_mask here?
Current shadow pages always have count_info == 0. If you add in extra flags
that you want preserved in shadow pages, you'll need some modifications like
in your last patch.
-- Keir
next prev parent reply other threads:[~2009-03-04 16:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 8:46 [PATCH]Add a flag for shadow pages Jiang, Yunhong
2009-03-04 9:06 ` Keir Fraser
2009-03-04 9:17 ` Jiang, Yunhong
2009-03-04 9:22 ` Keir Fraser
2009-03-04 9:28 ` Jiang, Yunhong
2009-03-04 9:56 ` Keir Fraser
2009-03-04 11:57 ` Keir Fraser
2009-03-04 12:13 ` Tim Deegan
2009-03-04 13:19 ` Keir Fraser
2009-03-04 14:30 ` Keir Fraser
2009-03-04 16:01 ` Jiang, Yunhong
2009-03-04 16:32 ` Gianluca Guida
2009-03-05 2:41 ` Jiang, Yunhong
2009-03-04 16:45 ` Keir Fraser [this message]
2009-03-04 9:20 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5D460AA.4191%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Gianluca.Guida@eu.citrix.com \
--cc=Tim.Deegan@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.