From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Test tap devices in testDeviceComplete()
Date: Tue, 10 Mar 2009 10:01:55 +0000
Message-ID: <C5DBEB13.498E%keir.fraser@eu.citrix.com>
References: <200903101031.47873.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200903101031.47873.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Jiri Denemark <jdenemar@redhat.com>
List-Id: xen-devel@lists.xenproject.org

On 10/03/2009 09:31, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

>> XendDomainInfo.testDeviceComplete() should check block devices have
>> shutdown correctly but it only considers vbd class devices and ignores tap
>> devices. The attached patch changes testDeviceComplete() to wait for both
>> vbd and tap devices to be shutdown correctly.
> 
> Has this also been tested with PV guests ?  In that case, there are no tap
> devices to shutdown.

Tap vs vbd is orthogional to PV vs HVM. Either type of guest can use either
type of storage backend. This detail is hidden from blkfront.

 -- Keir