From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] fs-backend: fix compile problems Date: Wed, 18 Mar 2009 17:26:29 +0000 Message-ID: References: <155851.243.qm@web56102.mail.re3.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0285329372==" Return-path: In-Reply-To: <155851.243.qm@web56102.mail.re3.yahoo.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "bderzhavets@yahoo.com" , Stefano Stabellini Cc: xen-devel List-Id: xen-devel@lists.xenproject.org > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --===============0285329372== Content-type: multipart/alternative; boundary="B_3320241995_10334512" > This message is in MIME format. Since your mail reader does not understand this format, some or all of this message may not be legible. --B_3320241995_10334512 Content-type: text/plain; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Just fixed this one in cs 19388. -- Keir On 18/03/2009 16:13, "Boris Derzhavets" wrote: > The most recent Xen Unstable installed:- > make xen OK > make install-xen OK > make tools=20 >=20 >=20 > gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g > -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-val= ue > -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xc_domain_restor= e.o.d > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE > -I../../xen/common/libelf -Werror -Wmissing-prototypes -I. -I../xenstore > -I../include -c -o xc_domain_restore.o xc_domain_restore.c > gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g > -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-val= ue > -Wdeclaration-after-statement -D__XEN_TOOLS__ -MMD -MF .xc_domain_save.o= .d > -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE > -I../../xen/common/libelf -Werror -Wmissing-prototypes -I. -I../xenstore > -I../include -c -o xc_domain_save.o xc_domain_save.c > cc1: warnings being treated as errors > xc_domain_save.c: In function =8Clock_suspend_event=B9: > xc_domain_save.c:764: error: ignoring return value of =8Cwrite=B9, declared w= ith > attribute warn_unused_result > make[4]: *** [xc_domain_save.o] Error 1 > make[4]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc' > make[3]: *** [build] Error 2 > make[3]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc' > make[2]: *** [subdir-install-libxc] Error 2 > make[2]: Leaving directory `/usr/src/xen-unstable.hg/tools' > make[1]: *** [subdirs-install] Error 2 > make[1]: Leaving directory `/usr/src/xen-unstable.hg/tools' > make: *** [install-tools] Error 2 >=20 > I belive requires same patch as fs-backend.c >=20 >=20 > Boris >=20 >=20 >=20 > --- On Wed, 3/18/09, Keir Fraser wrote: >> From: Keir Fraser >> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems >> To: "bderzhavets@yahoo.com" , "Stefano Stabellini= " >> >> Cc: "xen-devel" >> Date: Wednesday, March 18, 2009, 11:00 AM >>=20 >> Re: [Xen-devel] [PATCH] fs-backend: fix compile problems Upgrade to late= st >> xen-unstable. It=B9s fixed there. >>=20 >> -- Keir >>=20 >> On 18/03/2009 14:53, "Boris Derzhavets" wrote: >>=20 >>> Now "make install-xen" fails :- >>>=20 >>> make[6]: Entering directory >>> `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mcheck' >>> gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g >>> -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-v= alue >>> -Wdeclaration-after-statement -nostdinc -fno-builtin -fno-common >>> -iwithprefix include -Werror -Wno-pointer-arith -pipe >>> -I/usr/src/xen-unstable.hg/xen/include >>> -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic >>> -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-floa= t >>> -fno-stack-protector -mno-red-zone -fpic -fno-reorder-blocks >>> -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__X= EN__ >>> -DVERBOSE -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER -MMD -MF >>> .mce_intel.o.d -c mce_intel.c -o mce_intel.o >>> mce_intel.c:17: error: static declaration of =8Cfirstbank=B9 follows non-st= atic >>> declaration >>> x86_mca.h:95: error: previous declaration of =8Cfirstbank=B9 was here >>> make[6]: *** [mce_intel.o] Error 1 >>> make[6]: Leaving directory >>> `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mcheck' >>> make[5]: *** [mcheck/built_in.o] Error 2 >>> make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu' >>> make[4]: *** [cpu/built_in.o] Error 2 >>> make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' >>> make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2 >>> make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86' >>> make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2 >>> make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen' >>> make[1]: *** [install] Error 2 >>> make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen' >>> make: *** [install-xen] Error 2 >>>=20 >>>=20 >>> --- On Wed, 3/18/09, Boris Derzhavets wrote: >>>> From: Boris Derzhavets >>>> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems >>>> To: "Stefano Stabellini" >>>> Cc: "xen-devel" >>>> Date: Wednesday, March 18, 2009, 10:48 AM >>>>=20 >>>> Thank you. It's done >>>> Boris >>>>=20 >>>> --- On Wed, 3/18/09, Stefano Stabellini >>>> wrote: >>>>> From: Stefano Stabellini >>>>> Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems >>>>> To: "bderzhavets@yahoo.com" >>>>> Cc: "xen-devel" >>>>> Date: Wednesday, March 18, 2009, 10:19 AM >>>>>=20 >>>>> Boris Derzhavets wrote: >>>>>=20 >>>>>> > Removed unresolved reference in >>>>>> > /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined refe= rence >>>>>> > to `pci_emulation_add' >>>>>> >=20 >>>>>> > /* for (i =3D 0; i < nb_pci_emulation; i++) { >>>>>> > if(pci_emulation_add(pci_emulation_config_text[i]) < 0) >>>>> { >>>>>> > fprintf(stderr, "Warning: could not add PCI device >>>>> %s\n", >>>>>> > pci_emulation_config_text[i]); >>>>>> > } >>>>>> > } >>>>>> > */ >>>>>> >=20 >>>>>> > "make tools" completed OK. >>>>>> > Is it acceptable ? >>>>>> >=20 >>>>>=20 >>>>>=20 >>>>>=20 >>>>> I think we are missing an ifdef >>>>> CONFIG_PASSTHROUGH >>>>>=20 >>>>>=20 >>>>> diff --git a/vl.c b/vl.c >>>>> index 9b9f7d5..6c0ffb3 100644 >>>>> --- a/vl.c >>>>> +++ b/vl.c >>>>> @@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp) >>>>> } >>>>> } >>>>> =20 >>>>> +#ifdef CONFIG_PASSTHROUGH >>>>> for (i =3D 0; i < nb_pci_emulation; i++) { >>>>> if(pci_emulation_add(pci_emulation_config_text[i]) < 0) { >>>>> fprintf(stderr, "Warning: could not add PCI device >>>>> %s\n", >>>>> pci_emulation_config_text[i]); >>>>> } >>>>> } >>>>> +#endif >>>>> =20 >>>>> if (strlen(direct_pci_str) > 0) >>>>> direct_pci =3D >>>>> direct_pci_str; >>>>>=20 >>>>> _______________________________________________ >>>>> Xen-devel mailing list >>>>> Xen-devel@lists.xensource.com >>>>> http://lists.xensource.com/xen-devel >>>>=20 >>>> =20 >>>> _______________________________________________ >>>> Xen-devel mailing list >>>> Xen-devel@lists.xensource.com >>>> http://lists.xensource.com/xen-devel >>>=20 >>> =20 >> =20 >=20 > =20 --B_3320241995_10334512 Content-type: text/html; charset="ISO-8859-1" Content-transfer-encoding: quoted-printable Re: [Xen-devel] [PATCH] fs-backend: fix compile problems Just fixed this one in cs 19388.

 -- Keir

On 18/03/2009 16:13, "Boris Derzhavets" <bderzhavets@yahoo.com> wrote:

<= SPAN STYLE=3D'font-size:11pt'>The most recent Xen Unstable installed:-
make xen OK
make install-xen OK
make tools


gcc  -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -= fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -= Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD -MF .xc_domain_resto= re.o.d  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../..= /xen/common/libelf -Werror -Wmissing-prototypes  -I. -I../xenstore -I..= /include -c -o xc_domain_restore.o xc_domain_restore.c
gcc  -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -= fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -= Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD -MF .xc_domain_save.= o.d  -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_GNU_SOURCE -I../../xe= n/common/libelf -Werror -Wmissing-prototypes  -I. -I../xenstore -I../in= clude -c -o xc_domain_save.o xc_domain_save.c
cc1: warnings being treated as errors
xc_domain_save.c: In function ‘lock_suspend_event’:
xc_domain_save.c:764: error: ignoring return value of ‘write’, = declared with attribute warn_unused_result
make[4]: *** [xc_domain_save.o] Error 1
make[4]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc'
make[3]: *** [build] Error 2
make[3]: Leaving directory `/usr/src/xen-unstable.hg/tools/libxc'
make[2]: *** [subdir-install-libxc] Error 2
make[2]: Leaving directory `/usr/src/xen-unstable.hg/tools'
make[1]: *** [subdirs-install] Error 2
make[1]: Leaving directory `/usr/src/xen-unstable.hg/tools'
make: *** [install-tools] Error 2

I belive requires same patch as fs-backend.c


Boris



--- On Wed, 3/18/09, Keir Fraser <keir.fraser@eu.citrix.com> wrote:
<= SPAN STYLE=3D'font-size:11pt'>From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "bderzhavets@yahoo.com" &= lt;bderzhavets@yahoo.com>, "Stef= ano Stabellini" <Stefano.= Stabellini@eu.citrix.com>
Cc: "xen-devel" <xen-d= evel@lists.xensource.com>
Date: Wednesday, March 18, 2009, 11:00 AM

Re: [Xen-devel] [PATCH] fs-backend: fix compile problems Upgrade to latest = xen-unstable. It’s fixed there.

 -- Keir

On 18/03/2009 14:53, "Boris Derzhavets" <bderzhavets@yahoo.com> wrote:

<= SPAN STYLE=3D'font-size:11pt'>Now "make install-xen" fails :-

make[6]: Entering directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mche= ck'
gcc -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g -fno-st= rict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdecla= ration-after-statement  -nostdinc -fno-builtin -fno-common -iwithprefix= include -Werror -Wno-pointer-arith -pipe -I/usr/src/xen-unstable.hg/xen/inc= lude  -I/usr/src/xen-unstable.hg/xen/include/asm-x86/mach-generic -I/us= r/src/xen-unstable.hg/xen/include/asm-x86/mach-default -msoft-float -fno-sta= ck-protector -mno-red-zone -fpic -fno-reorder-blocks -fno-asynchronous-unwin= d-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -g -D__XEN__ -DVERBOSE -fno-omit-fra= me-pointer -DCONFIG_FRAME_POINTER -MMD -MF .mce_intel.o.d -c mce_intel.c -o = mce_intel.o
mce_intel.c:17: error: static declaration of ‘firstbank’ follow= s non-static declaration
x86_mca.h:95: error: previous declaration of ‘firstbank’ was he= re
make[6]: *** [mce_intel.o] Error 1
make[6]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu/mchec= k'
make[5]: *** [mcheck/built_in.o] Error 2
make[5]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86/cpu'
make[4]: *** [cpu/built_in.o] Error 2
make[4]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
make[3]: *** [/usr/src/xen-unstable.hg/xen/arch/x86/built_in.o] Error 2
make[3]: Leaving directory `/usr/src/xen-unstable.hg/xen/arch/x86'
make[2]: *** [/usr/src/xen-unstable.hg/xen/xen] Error 2
make[2]: Leaving directory `/usr/src/xen-unstable.hg/xen'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/usr/src/xen-unstable.hg/xen'
make: *** [install-xen] Error 2


--- On Wed, 3/18/09, Boris Derzhavets <bderzhavets@yahoo.com> wrote:
<= SPAN STYLE=3D'font-size:11pt'>From: Boris Derzhavets <bderzhavets@yahoo.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel" <xen-d= evel@lists.xensource.com>
Date: Wednesday, March 18, 2009, 10:48 AM

Thank you. It's done
Boris

--- On Wed, 3/18/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
<= SPAN STYLE=3D'font-size:11pt'>From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "bderzhavets@yahoo.com" &= lt;bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-d= evel@lists.xensource.com>
Date: Wednesday, March 18, 2009, 10:19 AM

Boris Derzhavets wrote:

> Removed unresolved reference in
> /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined referenc= e
> to `pci_emulation_add'
>
> /*    for (i =3D 0; i < nb_pci_emulation; i++) {
>         if(pci_emulation_add(p= ci_emulation_config_text[i]) < 0)
 {
>            &nbs= p;fprintf(stderr, "Warning: could not add PCI device
%s\n",
>            &nbs= p;        pci_emulation_config_text[= i]);
>         }
>     }
> */
>
> "make tools" completed OK.
> Is it acceptable ?
>



I think we are missing an ifdef
 CONFIG_PASSTHROUGH


diff --git a/vl.c b/vl.c
index 9b9f7d5..6c0ffb3 100644
--- a/vl.c
+++ b/vl.c
@@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp)
         }
     }
 
+#ifdef CONFIG_PASSTHROUGH
     for (i =3D 0; i < nb_pci_emulation; i++) {          if(pci_emulation_add(= pci_emulation_config_text[i]) < 0) {
            &nb= sp;fprintf(stderr, "Warning: could not add PCI device
%s\n",
            &nb= sp;        pci_emulation_config_text= [i]);
         }
     }
+#endif
 
     if (strlen(direct_pci_str) > 0)
         direct_pci =3D
 direct_pci_str;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com http://lists.xensource.com/x= en-devel
=
 
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com http://lists.xensource.com/x= en-devel
=
 
=
=
 
--B_3320241995_10334512-- --===============0285329372== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0285329372==--