From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume
Date: Tue, 31 Mar 2009 18:35:27 +0100
Message-ID: <C5F812EF.61E8%keir.fraser@eu.citrix.com>
References: <20090331172423.GA70062@zanzibar.lan>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090331172423.GA70062@zanzibar.lan>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Brendan Cully <brendan@cs.ubc.ca>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: "andy@cs.ubc.ca" <andy@cs.ubc.ca>, kmansley@solarflare.com
List-Id: xen-devel@lists.xenproject.org

On 31/03/2009 18:24, "Brendan Cully" <brendan@cs.ubc.ca> wrote:

> The other is in the netfront accelerator. It tears down a xenstore
> watch on the accelerator path at every suspend, and adds the watch
> back on resume. As with any xenstore interaction, this can
> occasionally take a very long time. I'm going from faulty memory here,
> but I didn't think it was necessary to tear down and restore watches
> across suspend. Would it make sense to move the watch remove and add
> into the resume hook (taking it completely out of suspend and
> suspend_cancel)?

They have to be renewed on full resume, but of course they do not get reset
across a cancelled suspend. Kieran may be able to advise on changing the net
accel code.

 -- Keir