From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume Date: Wed, 01 Apr 2009 11:31:46 +0100 Message-ID: References: <1238581584.4440.18.camel@moonstone.uk.level5networks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1238581584.4440.18.camel@moonstone.uk.level5networks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kieran Mansley , Brendan Cully Cc: "andy@cs.ubc.ca" , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 01/04/2009 11:26, "Kieran Mansley" wrote: >> Could it be as simple as this? I can't remember what happens if >> unregister_xenbus_watch is called after the xenbus connection has been >> reset. Should we just free the guest structures without interacting >> with xenstore at the start of the resume method? > > It may be possible to synchronise the watch handler with the > suspend/resume/cancel cycle without removing the watch, but that starts > to get complicated. Could we avoid any of this logic executing if there are no net accelerators? -- Keir