From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Skip vcpu_hotplug for VCPU 0 in smp_resume
Date: Thu, 02 Apr 2009 09:27:58 +0100
Message-ID: <C5FA359E.64C3%keir.fraser@eu.citrix.com>
References: <1238659983.4271.6.camel@moonstone.uk.level5networks.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1238659983.4271.6.camel@moonstone.uk.level5networks.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Kieran Mansley <kmansley@solarflare.com>, Brendan Cully <brendan@cs.ubc.ca>
Cc: "andy@cs.ubc.ca" <andy@cs.ubc.ca>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 02/04/2009 09:13, "Kieran Mansley" <kmansley@solarflare.com> wrote:

> On Wed, 2009-04-01 at 11:39 -0700, Brendan Cully wrote:
>> I'm afraid my memory of the kernel suspend mechanics has gotten a bit
>> rusty over the last few months, so I may be off-base here. But I
>> thought that xs_suspend masked watches until xs_reusume or
>> xs_suspend_cancel? If that is the case, isn't that on its own enough
>> to protect netfront?
> 
> If that's the case, it should be enough, yes.
> 
> Do watches that would have fired during that time fire at the end of
> masked period?  If not, we'd still have to access xenstore on suspend
> cancel to check if we've missed a change.

I don't think watches get lost across suspend-cancel, just delayed.

 -- Keir