From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Thomas Pfeuffer <thomas.pfeuffer@mytum.de>,
"Yu, Ke" <ke.yu@intel.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] only set scheduler timer for non-idle CPU
Date: Thu, 02 Apr 2009 14:06:27 +0100 [thread overview]
Message-ID: <C5FA76E3.5880%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <49D4B41C.9030901@mytum.de>
[-- Attachment #1.1: Type: text/plain, Size: 753 bytes --]
On 02/04/2009 13:48, "Thomas Pfeuffer" <thomas.pfeuffer@mytum.de> wrote:
> Hello Ke,
>>
>> It is not necessary to set scheduler timer for idle CPU. so this patch add
>> conditional check for idle CPU.
>>
> I think your patch is not good in case sedf-scheduler is used. If idle VCPU is
> the current "running" VCPU, the scheduler timer is set to the next "period
> begin" of the first VCPU in the wait queue.
> Your patch prevents sedf from taking the VCPUs waiting for their next period
> into the runnable queue again.
It¹s probably cleaner always to respect the specific scheduler¹s scheduling
quantum in schedule.c, but then have sched_credit.c return a very large
quantum (large as possible) for the idle VCPU.
-- Keir
[-- Attachment #1.2: Type: text/html, Size: 1513 bytes --]
[-- Attachment #2: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2009-04-02 13:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 3:14 [PATCH] only set scheduler timer for non-idle CPU Yu, Ke
2009-04-01 14:02 ` Tian, Kevin
2009-04-02 12:48 ` Thomas Pfeuffer
2009-04-02 13:06 ` Keir Fraser [this message]
2009-04-02 13:18 ` Keir Fraser
2009-04-03 1:32 ` Yu, Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5FA76E3.5880%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=ke.yu@intel.com \
--cc=thomas.pfeuffer@mytum.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.