From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: do_domctl and EAGAIN Date: Tue, 07 Apr 2009 09:03:02 +0100 Message-ID: References: <49DB0392.2060103@ts.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <49DB0392.2060103@ts.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Juergen Gross Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 07/04/2009 08:41, "Juergen Gross" wrote: > Keir Fraser wrote: >> Only DOMCTL_destroydomain returns EAGAIN. No domctl returns EINTR. > > do_domctl uses ioctl. > ioctl can return EINTR if a signal is caught. Our privcmd hypercall ioctl() is non-blocking and hence I don't think can return EINTR. In fact ioctl() is used in loads of places throughout our toolstack and in qemu, and I don't think EINTR is checked by any caller, nor is EINTR mentioned in the ioctl man page. -- Keir