From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] 1/1 Better expose xenstore limits Date: Thu, 30 Apr 2009 10:35:17 +0100 Message-ID: References: <1241081691.5394.192.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1241081691.5394.192.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 30/04/2009 09:54, "Tim Post" wrote: >> Defining the same thing again but with a different name just for purposes of >> documentation is pretty barking. I suppose it is perhaps worth a >> documentation comment in xs.h, but no more than that. > > It is worth a mention... though it seems silly to send a patch that adds > comments. However, a patch that would convert the comments in xs to > doxygen format seems more useful, with the appropriate grouping, shorts, > etc. > > How receptive would you be to that? I don't have a strong opinion. You can go wild on that if you like, assuming noone else hates doxygen format for any reason. I added a limits-related comment to xs.h by the way. -- Keir