From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Question about the dynamic sizing of the PCI hole
Date: Mon, 25 May 2009 10:42:23 +0100
Message-ID: <C640268F.BBAE%keir.fraser@eu.citrix.com>
References: <8686c3cd0905250224k320537b3s3b9cbcc0fd3ce51@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="ISO-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <8686c3cd0905250224k320537b3s3b9cbcc0fd3ce51@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tom Rotenberg <tom.rotenberg@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

That field is updated dynamically. Can't you fluently read ASL? ;-)

 -- Keir

On 25/05/2009 10:24, "Tom Rotenberg" <tom.rotenberg@gmail.com> wrote:

> And, won't we have any problem if we dynamically size the PCI hole, and n=
ot
> update it in the DSDT we give for the HVM (in the DSDT it's always
> 0xf0000...)?
>=20
> 2009/5/25 Keir Fraser <keir.fraser@eu.citrix.com>
>> On 25/05/2009 10:01, "Tom Rotenberg" <tom.rotenberg@gmail.com> wrote:
>>=20
>>> I am reviewing the code of the hvmloader from Xen 3.4, and i saw that i=
n
>>> changeset 19021, there was a patch which added the ability to dynamical=
ly
>>> size
>>> the PCI hole. I have seen that this patch calculates the total memory s=
ize,
>>> but i failed to understand the following lines:
>>>=20
>>> while ( (mmio_total > (pci_mem_end - pci_mem_start)) &&
>>> =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ((pci_mem_start << 1) !=3D 0) )
>>> =A0=A0=A0=A0=A0=A0=A0 pci_mem_start <<=3D 1;
>>>=20
>>> It looks as if the pci mem start will be increased if there isn't enoug=
h
>>> space
>>> for the PCI devices, although, as far as i understand, it should be
>>> decreased
>>> (so the PCI hole will be enlarged). So, shouldn't it be: "pci_mem_start=
 >> =3D
>>> 1" ?
>>=20
>> Leading bits of this 32-bit value are 1s. Hence left shift is what we wa=
nt.
>>=20
>> =A0-- Keir
>>=20
>>=20
>=20