From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Nigel Gamble <nigel@nrg.org>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] minios: replace mktime implementation
Date: Wed, 27 May 2009 20:05:11 +0100 [thread overview]
Message-ID: <C6434D77.C00C%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <3EE061F6-1589-4725-89CF-0780FA867F6F@nrg.org>
On 27/05/2009 19:21, "Nigel Gamble" <nigel@nrg.org> wrote:
>> I checked and going back in time in 2003 entry.S in MiniOS has been
>> rewritten to be able to license MiniOS under BSD, so we should be
>> fine.
>
> Yes, it looks like this is true of x86_32.S, but it looks to me as if
> x86_64.S was missed, because it is still clearly derived from Linux,
> not BSD.
Yes, you're quite obviously right. Stefano, we should at least remove all
the commented out Linux code (most of which is CFI_* stack unwinding
directives) and probably expand out many of the macros, most of which are
used only once anyway. Plus rename/reorg where possible in line with
x86_32.S. That's maybe an hour's work at most and I'd be comfortable
claiming copyright on the result, or at least I'm certain it would be as
clean as x86_32.S at that point (Which was never clean-room rewritten).
-- Keir
prev parent reply other threads:[~2009-05-27 19:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 13:08 [PATCH] minios: replace mktime implementation Stefano Stabellini
2009-05-22 18:35 ` Nigel Gamble
2009-05-26 15:07 ` Stefano Stabellini
2009-05-27 18:21 ` Nigel Gamble
2009-05-27 19:05 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6434D77.C00C%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=nigel@nrg.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.