From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] xen: fix s3 resume on AMD CPUs
Date: Fri, 05 Jun 2009 09:21:26 +0100
Message-ID: <C64E9416.CDC3%keir.fraser@eu.citrix.com>
References: <200906051000.52397.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200906051000.52397.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 05/06/2009 09:00, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> attached patch fixes S3 resume on AMD CPUs.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Please make a minimal patch and explain each individual change. This one has
bizarre additional alignment, nops, double short jumps, longjmp->shortjmp
but keeps a comment which is then incorrect. Why are they needed? Is the
need documented? I don't see anything similar in Linux 2.6.27 wakeup
routines (2.6.27 is what I happen to have to hand).

I won't take your random permutations on this file of all files especially,
since it is a pain in the arse to debug when it gets broken.

 -- Keir