From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH][SVM] fix spinlock panic
Date: Thu, 18 Jun 2009 10:47:07 +0100
Message-ID: <C65FCBAB.DA80%keir.fraser@eu.citrix.com>
References: <200906181125.36369.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200906181125.36369.Christoph.Egger@amd.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 18/06/2009 10:25, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

>> dangerous to reset the ASID generation back to zero); Also, as well as not
>> reallocating hsa and root_vmcb, we don't re-init them either. I don't know
>> ehether that strictly matters but obviously we could easily re-jig the code
>> to always clear_page() those pages unconditionally.
> 
> Thanks for it. Regarding ASID, I will ask back.
> Now, I trigger an ASSERT() called by setup_vmcb_dump():
> 
> (XEN) Assertion 'key_table[key].u.handler == ((void*)0)' failed at
> keyhandler.c:68

Oh good grief, I got the test at the top of start_svm() inverted. Please try
changeset 19798 which fixes this.

 -- Keir