From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 2/6] Change the boot allocator function to support memory add Date: Sun, 28 Jun 2009 10:50:24 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Jiang, Yunhong" , Jan Beulich , Tim Deegan , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 28/06/2009 10:27, "Jiang, Yunhong" wrote: > This patch extend the boot allocator to support memory add. > > We take different method for boot allocator bitmap for 32/64 system. In x32 , > we allocate 512K bitmap to support the whole 16G memory. In x86_64, we don't > change the allocation when system bootup, instead, we try to remap the > allocator bitmap to some pre-defined virtual address if hot-add happen. > > We also add several API to allocate the handle boot page from some range. The undelrying implementation ideas may be okay, but calling these extensions to the 'boot allocator' makes no sense. The boot allocator only exists during boot. The fact that the bitmap it uses persists beyond boot is an implementation detail. Perhaps you just need to change the name of your new allocator interface functions to something more suitable. -- Keir