From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] x86, hvm: Allow delivery of timer interrupts to VCPUs != 0. Date: Fri, 03 Jul 2009 07:41:46 +0100 Message-ID: References: <7k4otuo0g8.fsf@pingu.sky.yk.fujitsu.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7k4otuo0g8.fsf@pingu.sky.yk.fujitsu.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kouya Shimura , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This doesn't look too bad, given the current vpt interface we have. My main comment is regarding vpit_vcpu(), vrtc_vcpu() and vhpet.vcpu. Seems all of these could unconditionally use i8259_target. I suggest also introducing vhpet_vcpu(), and then pointing all three *_vcpu() macros at pt_i8259_target() only. And get rid of the vhpet.vcpu field. Would that work okay? -- Keir On 03/07/2009 05:27, "Kouya Shimura" wrote: > This patch is needed for kexec/kdump since kdump may halt VCPU#0. > > Signed-off-by: Kouya Shimura >