From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: 32-on-64 support in xen-unstable?
Date: Mon, 06 Jul 2009 16:23:24 +0100
Message-ID: <C677D57C.89EF%keir.fraser@eu.citrix.com>
References: <4A5207B1.3030808@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4A5207B1.3030808@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Chris Lalancette <clalance@redhat.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 06/07/2009 15:18, "Chris Lalancette" <clalance@redhat.com> wrote:

> However, looking at arch/x86/mm.c:mod_l4_entry(), it returns 0 on success and
> <
> 0 on error.  It seems to me that booting a 32-bit PV guest is always going to
> fall into the !okay check on success, when it really shouldn't.

You didn't spot the '== 0' tacked on the end of that long ternary
expression?

 -- Keir