From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: [PATCH] Fix xentop on pv-ops domain0
Date: Tue, 07 Jul 2009 08:15:42 +0100
Message-ID: <C678B4AE.EFBA%keir.fraser@eu.citrix.com>
References: <EADF0A36011179459010BDF5142A457501C9FA936D@pdsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <EADF0A36011179459010BDF5142A457501C9FA936D@pdsmsx502.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Xu, Dongxiao" <dongxiao.xu@intel.com>, "echo@echoreply.us" <echo@echoreply.us>, Christoph Egger <Christoph.Egger@amd.com>, Steven Maresca <steve.maresca@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Please send a final patch.

 Thanks,
 Keir

On 07/07/2009 01:37, "Xu, Dongxiao" <dongxiao.xu@intel.com> wrote:

> Using "/sys/bus/xen-backend/devices/" is fine, formerly I didn't notice there
> was a link in this directory. Thanks!
> 
> Best Regards, 
> -- Dongxiao
> 
> -----Original Message-----
> From: Tim Post [mailto:echo@echoreply.us]
> Sent: Tuesday, July 07, 2009 12:02 AM
> To: Christoph Egger
> Cc: Xu, Dongxiao; xen-devel@lists.xensource.com; keir.fraser@eu.citrix.com
> Subject: Re: [Xen-devel] [PATCH] Fix xentop on pv-ops domain0
> 
> Hi,
> 
> On Mon, 2009-07-06 at 17:49 +0200, Christoph Egger wrote:
>> This patch is good.
>> 
> 
> The following is going to break xenstat on almost every forward port of
> 2.6.18.8 (including Andy's 2.6.30 vanilla port):
> 
> 
> +       if (strncmp(system_info.release, "2.6.18.8-xen",
> +               sizeof("2.6.18.8-xen")) == 0)
> +               sysfs_vbd_path = "/sys/devices/xen-backend/";
> +       else
> +               sysfs_vbd_path = "/sys/devices/";
> +
> 
> I would really recommend considering just
> using /sys/bus/xen-backend/devices, as Stephen noted.
> 
> Cheers,
> --Tim
> 
>