From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Error restoring DomU when using GPLPV
Date: Tue, 04 Aug 2009 14:12:48 +0100
Message-ID: <C69DF260.9ECD%keir.fraser@eu.citrix.com>
References: <AEC6C66638C05B468B556EA548C1A77D016DE05D@trantor>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <AEC6C66638C05B468B556EA548C1A77D016DE05D@trantor>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: James Harper <james.harper@bendigoit.com.au>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Joshua West <jwest@brandeis.edu>
List-Id: xen-devel@lists.xenproject.org

On 04/08/2009 12:34, "James Harper" <james.harper@bendigoit.com.au> wrote:

>> Like I said before -- unmapping the gnttab pages I think will not help
> you
>> for live migration, but I suppose it is a reasonable thing to do
> anyway. For
>> live migration I think xc_domain_save needs t get a bit smarter about
>> Xenheap pages in HVM guests.
> 
> Understood. Do you have any idea about why it worked fine under 3.3.x
> but not 3.4.x?

The bit of code in 3.3's xc_domain_save.c that is commented "Skip PFNs that
aren't really there" is removed in 3.4. That will be the reason.

 -- Keir