From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] pvcpuid: mask TSC invariant bit for various circumstances Date: Tue, 27 Oct 2009 00:22:06 +0000 Message-ID: References: <8a95a56e-c387-46c7-a7d2-5a84bdfd1485@default> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8a95a56e-c387-46c7-a7d2-5a84bdfd1485@default> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer , "Xen-Devel (E-mail)" List-Id: xen-devel@lists.xenproject.org On 26/10/2009 23:12, "Dan Magenheimer" wrote: > pvcpuid: mask TSC invariant bit for PV domains if migration > is not disabled and TSC is not emulated > > (Need similar patch for HVM domain) > > Signed-off-by: Dan Magenheimer This only affects PV domUs. I suggest patching pv_cpuid() to catch dom0, and then really all domUs should be handled by xc_cpuid_apply_policy(), which pushes CPUID info down to the hypervisor, as called from xend's image.py:setCpuid(). The advantage of this is that the hypervisor does not need to be informed of the 'disable_migrate' flag at all -- it can be assumed to be true for dom0 -- and it can be handled entirely in the tools. Hence I can get rid of the new domctl, which is nice. -- Keir