From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] pvcpuid: mask TSC invariant bit for various circumstances Date: Tue, 27 Oct 2009 07:31:36 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer , "Xen-Devel (E-mail)" List-Id: xen-devel@lists.xenproject.org On 27/10/2009 01:09, "Dan Magenheimer" wrote: >> This only affects PV domUs. I suggest patching pv_cpuid() to >> catch dom0, and >> then really all domUs should be handled by >> xc_cpuid_apply_policy(), which >> pushes CPUID info down to the hypervisor, as called from xend's >> image.py:setCpuid(). The advantage of this is that the >> hypervisor does not >> need to be informed of the 'disable_migrate' flag at all -- it can be >> assumed to be true for dom0 -- and it can be handled entirely >> in the tools. >> Hence I can get rid of the new domctl, which is nice. > > I'm not done using the disable_migrate flag yet though. > This was just low-hanging fruit. Okay. Well I nack this new patch anyway. -- Keir