Re: Re: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove

[Keir Fraser <keir.fraser@eu.citrix.com>]

On 09/12/2009 11:20, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

> What's PROC_BASE, and what's APIC_MADT_PTR? No comments attached to them:
> they look like random magic numbers.
> 
> DSDT code generation can be done in mk_dsdt.c, rather then addign
> preprocessor stuff to the static part of the DSDT in dsdt.asl. So move stuff
> there instead.
> 
> What's the MADT checksum stuff in the DSDT all about? Does the MADT really
> have to stay consistent and checksummed after boot - I would have assumed
> that it provides a boot-time snapshot of the system only, and would not be
> looked at by the OSPM after boot. I haven't looked at the ASL code in detail
> but I'll surely bet that the approach is fragile.

Ah, this has to do with the _MAT methods doesn't it. Well, I wonder whether
the strategy of sharing the _MAT return values and the MADT entries is
actually sensible. There seems to be no really good reason to do it -- they
should be consistent at boot-time of course, but after boot the MADT isn't
expected to remain live and up-to-date I believe? Then each Processor object
can define its own MAT buffer which it manages entirely by and for itself.

 -- Keir