From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH 2] HVM vcpu add/remove: setup dsdt and madt infrastructure for vcpu add/remove Date: Thu, 10 Dec 2009 20:14:01 +0000 Message-ID: References: <706158FABBBA044BAD4FE898A02E4BC201CF7CA731@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <706158FABBBA044BAD4FE898A02E4BC201CF7CA731@pdsmsx503.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Liu, Jinsong" , xen-devel List-Id: xen-devel@lists.xenproject.org On 10/12/2009 12:08, "Liu, Jinsong" wrote: >> What's PROC_BASE, and what's APIC_MADT_PTR? No comments attached to >> them: they look like random magic numbers. > > KVM has vcpu add/remove code, these 2 items learn from KVM qemu/vbios/dsdt > code. > Since they belong to qemu & vbios part, I think we'd better keep same with > KVM. > I will add comments for them at updated patch. Oh, I categorically do not care about keeping these magic numbers the same as KVM/qemu. If there are some ioports or iomem emulated at fixed address by qemu then that's one thing, but keeping their vbios random numbers when we *do not use* the same vbios makes no sense. I'd rather keep our MADT layout, add a few lines of code to hvmloader to describe some MADT position/layout parameters to the DSDT via the bios_info structure, and go from there. Smaller, clearer patch, as far as I can see. -- Keir