From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] Parallel/Serial/Monitor/pyGRUB ReiserFS/others support/fixes Date: Wed, 23 Dec 2009 07:50:19 +0000 Message-ID: References: <20091223005430.GA3449@router-fw-old.local.net-space.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20091223005430.GA3449@router-fw-old.local.net-space.pl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Daniel Kiper , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 23/12/2009 00:54, "Daniel Kiper" wrote: > xen-unstable-hvmloader-strip_20091222.patch: > Strip hvmloader after compile. dh_strip from debhelper > does not strip binaries without execute attribute. I don't see the point of doing this. We don't in general strip stuff we build under tools/, the extra disc space taken is trivial, and symbols can be convenient to have around. I just don't see the win. - Not applying to xen-unstable or xen-3.4 > xen-unstable-parallel-serial-monitor_20091223.patch: Xend parts look good. The hvmloader parts look unnecessary (since we currently always declare LPT1 present) and dangerous (Windows guests which were installed on old Xen iirc get upset if they later boot and see LTP1 not-present in ACPI tables). There'd need to be a *good* reason for hiding LTP1 in DSDT therefore. - Partially applied to unstable; not applied to 3.4 > xen-unstable-pygrub-reiserfs_20091222.patch: > Small but important correction for pyGRUB ReiserFS support. > Without this patch pyGRUB could not read ReiserFS. Looks good. - Applied to unstable and 3.4. > xen-unstable-videoram_20091222.patch: > Remove videoram option from vfb config. > This option is only valid in main config. Looks good but not critical for 3.4. - Applied to unstable; not applied to 3.4. -- Keir