Re: [PATCH] Parallel/Serial/Monitor/pyGRUB ReiserFS/others support/fixes

[Keir Fraser <keir.fraser@eu.citrix.com>]

Hopefully I've fixed this with c/s 20719.

 -- Keir

On 24/12/2009 07:43, "Xu, Dongxiao" <dongxiao.xu@intel.com> wrote:

> Hi, Daniel, 
> Could you help to check your patch which is checked in as C/S 20717?
> It seems that VM save/restore/migration and reboot is broken since this
> changeset.
> 
> Thanks!
> Dongxiao
> 
> Daniel Kiper wrote:
>> Hello,
>> 
>>>>>> xen-unstable-hvmloader-strip_20091222.patch:
>>>>>>   Strip hvmloader after compile. dh_strip from debhelper
>>>>>>   does not strip binaries without execute attribute.
>>>>> 
>>>>> I don't see the point of doing this. We don't in general strip
>>>>> stuff we build under tools/, the extra disc space taken is
>>>>> trivial, and symbols can be convenient to have around. I just
>>>>>  don't see the win. - Not applying to xen-unstable or xen-3.4
>>>> 
>>>> Yes, it is the packager's responsibility to take care of this if
>>>> they deem it necessary, either manually or by adding +x so that
>>>> dh_strip takes care of it.
>>> 
>>> Actually hvmloader seems to be a+x already, in all my build trees.
>> 
>> FYI:
>> xen-3.4.2/tools/firmware/hvmloader/hvmloader: 0755
>> xen-3.4.2/dist/install/usr/lib/xen/boot/hvmloader: 0644
>> 
>> OK, I agree that this patch break general
>> rule and should not be applied.
>> 
>>>> xen-unstable-parallel-serial-monitor_20091223.patch:
>>> 
>>> Xend parts look good. The hvmloader parts look unnecessary (since we
>>> currently always declare LPT1 present) and dangerous (Windows guests
>>> which were installed on old Xen iirc get upset if they later boot
>>> and see LTP1 not-present in ACPI tables). There'd need to be a
>>>  *good* reason for hiding LTP1 in DSDT therefore. - Partially
>>> applied to unstable; not applied to 3.4
>> 
>> 1) I think that parallel port configuration should be similar to
>>    serial port configuration. With that idea in mind this patch was
>>    created (and some code were copied from serial config).
>> 2) I tested this patch with Windows Vista Business SP2 and
>>    Finnix Ver. 92.1 as a guests and everything worked without
>>    any problem.
>> 3) I do not like that broken/disabled devices appear in config/device
>>    manager without any warning. In this situation disabled LPT1 port
>>    appear in Windows Device Manager without any warning. I think it
>>    is confusing for users when they see working devices in WDM and
>>    they could not use them.
>> 4) As I mentioned earlier, all patches (including this one) do not
>>    change default behavior of Xen. It means that default QEMU
>>    configuration is not changed when parallel option is not specified
>>    in config file. If somebody would like to disable LPT1, he/she
>>    should have possibility to do that in proper way. I think it is
>>    another question that he/she is aware what is he/she doing.
>> 
>> That is why I think
>> xen-unstable-parallel-serial-monitor_20091223.patch patch should be
>> fully applied. 
>> 
>> Daniel Kiper
>> 
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel