From mboxrd@z Thu Jan  1 00:00:00 1970
From: Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: xen_tlb_flush_all mfn validation panic
Date: Thu, 24 Dec 2009 16:01:09 +0000
Message-ID: <C75940C5.5338%keir.fraser@eu.citrix.com>
References: <C75939F9.5334%keir.fraser@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C75939F9.5334%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Kieran Mansley <kmansley@solarflare.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 24/12/2009 15:32, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

> On 24/12/2009 15:06, "Kieran Mansley" <kmansley@solarflare.com> wrote:
> 
>> The initial "bad gmfn" message seems to be due to an attempt to validate
>> the mfn argument to the mmuext_op.  It's not surprising to me that this
>> fails as xen_tlb_flush_all doesn't supply an mfn argument - it's not
>> needed for the MMUEXT_TLB_FLUSH_ALL command.  Is there something that is
>> supposed to mean that the mfn argument should be valid even when not
>> explicitly set by the caller, or is the validation of the mfn for all
>> mmuext_op commands a bug?
> 
> The explicit check for INVALID_MFN is new, and that is obviously a bug. I
> will sort out a suitable fix for this.

Should be fixed by c/s 20723.

 -- Keir