From: Keir Fraser <keir.fraser@eu.citrix.com>
To: Andre Przywara <andre.przywara@amd.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"yunhong.jiang@intel.com" <yunhong.jiang@intel.com>
Subject: Re: [PATCH] xend: Fix non-contiguous NUMA node assignment
Date: Mon, 18 Jan 2010 09:19:44 +0000 [thread overview]
Message-ID: <C779D830.67D1%keir.fraser@eu.citrix.com> (raw)
In-Reply-To: <4B542170.6000202@amd.com>
On 18/01/2010 08:53, "Andre Przywara" <andre.przywara@amd.com> wrote:
> Keir Fraser wrote:
>> I had a go myself: see c/s 20817. This keeps nr_nodes as well as
>> max_node_id, and continues to use it where it seemed to make sense to do so.
>
> c/s 20817 seems OK to me. Actually that was how I started, but then
> decided to drop max_node_id because I didn't see the sense in keeping
> two variables which actually differ just by 1.
They don't merely differ by one if there are holes in the node-id namespace.
Can that happen in practice? I'm not sure; but it's easy enough for the
tools to handle that case, so they might as well.
-- Keir
prev parent reply other threads:[~2010-01-18 9:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 13:28 [PATCH] xend: Fix non-contiguous NUMA node assignment Andre Przywara
2010-01-17 2:10 ` Jiang, Yunhong
2010-01-17 17:48 ` Keir Fraser
2010-01-17 18:55 ` Keir Fraser
2010-01-18 8:53 ` Andre Przywara
2010-01-18 9:19 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C779D830.67D1%keir.fraser@eu.citrix.com \
--to=keir.fraser@eu.citrix.com \
--cc=andre.przywara@amd.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.