From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] PV driver compatibility Date: Thu, 21 Jan 2010 21:46:56 +0000 Message-ID: References: <1264106300.21707.57.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1264106300.21707.57.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: ksrinivasan , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 21/01/2010 20:38, "Ian Campbell" wrote: >> You introduced the magic port value check, in xen-unstable:19964. > > I'm guilty of pretty poor changelogging there, aren't I, I've no idea > how the unmodified drivers part of the change relates to the comment :-( Yes, I wonder if it was even meant to be checked in. Or if it's an accidental merge of two patches both of which you intended to go in. I'm not sure unconditional unplug, as implemented, is a good idea. I can imagine people with setups in which emulated devices coexist with pv devices. Such a setup breaks if emulated devices all get unplugged when pv drivers load. Presumably in the environment this patch came from (Citrix XenServer) such a situation is disallowed, but I'm not so sure about proscribing it more generally. Some people do want unplug though, so I think making it a non-default module option is a good idea. -- Keir