From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] PV driver compatibility Date: Fri, 22 Jan 2010 08:03:17 +0000 Message-ID: References: <1264145504.21707.79.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1264145504.21707.79.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: ksrinivasan , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 22/01/2010 07:31, "Ian Campbell" wrote: > Yes, that's possible. I notice that I defined XEN_IOPORT_LINUX_PRODNUM > and XEN_IOPORT_LINUX_DRVVER but then hardcode 0xdead and 0xbeef where > they should be used, which suggests I wasn't quite ready to send the > patch... Hm, do you want to keep the deadbeef, or pick a nicer value, or remove the patch? > The protocol allows for coarse grained selection of which devices to > unplug: > 6) The drivers write a two-byte bitmask of devices to unplug to IO > port 0x10. The defined fields are: Well, the flexibility is nice, but not a feature that driver currently actually uses. My default action right now will be to add a module option to specify selective or complete flushing, keep the patch, but only fail to load drivers if flush is requested but not possible, otherwise just warn. -- Keir