From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keir Fraser Subject: Re: [PATCH] PV driver compatibility Date: Fri, 22 Jan 2010 09:07:45 +0000 Message-ID: References: <1264149821.21707.88.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1264149821.21707.88.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: ksrinivasan , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 22/01/2010 08:43, "Ian Campbell" wrote: >>> The protocol allows for coarse grained selection of which devices to >>> unplug: >>> 6) The drivers write a two-byte bitmask of devices to unplug to IO >>> port 0x10. The defined fields are: >> >> Well, the flexibility is nice, but not a feature that driver currently >> actually uses. >> >> My default action right now will be to add a module option to specify >> selective or complete flushing, keep the patch, but only fail to load >> drivers if flush is requested but not possible, otherwise just warn. > > Sounds good, what will the default flush setting be? None. Those who are switching from emulated to pv should know what they are doing and specify the module option. > Could you swap out the 0xdead and 0xbeef for the defines which are > specified right above the function in question while you are there? Yep. -- Keir